Streamline event emission and tracking #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
added
enhancement
aldesantis
force-pushed
the
aldesantis/improve-events
branch
from
2764122
to
10e73e6
Compare
aldesantis
force-pushed
the
aldesantis/improve-events
branch
from
10e73e6
to
30d2fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the flow followed by the extension when firing and tracking events.
Previously, a
SubscriptionEventrecord would be created first, which would then fire aSpree::Eventin anafter_createcallback. This wasn't a very intuitive flow and it didn't follow the conventions used in the core.Now, a
Spree::Eventis fired first thing. Then, a subscriber catches all events fired by this extension and saves them as aSubscriptionEventrecord under the related subscription.Using the built-in subscriber mechanism streamlines how we handle events and makes it more consistent with the core.